From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maksim Kokryashkin <max.kokryashkin@gmail.com>, tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2] Mark CONV as non-weak, to prevent elimination of its side-effect. Date: Tue, 3 Oct 2023 19:25:53 +0300 [thread overview] Message-ID: <038fe5c1-c421-78a4-02b1-2e0398010ce8@tarantool.org> (raw) In-Reply-To: <20231003133705.5700-1-max.kokryashkin@gmail.com> On 10/3/23 16:37, Maksim Kokryashkin wrote: > From: Mike Pall <mike> > > An unused guarded CONV int.num cannot be omitted in general. > > (cherry-picked from commit 881d02d3117838acaf4fb844332c8e33cc95c8c5) > > In some cases, an unused `CONV int.num` omission in `DUALNUM` mode I would add that DUALNUM could be enabled in CMake by "-DLUAJIT_NUMMODE=2" because it is not obvious and there is no documentation for CMake options. > may lead to a guard absence, resulting in invalid control flow > branching and undefined behavior. For a comprehensive example of > the described situation, please refer to the comment > in `test/tarantool-tests/mark-conv-non-weak.test.lua`. <snipped>
prev parent reply other threads:[~2023-10-03 16:25 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-03 13:37 Maksim Kokryashkin via Tarantool-patches 2023-10-03 16:24 ` Sergey Bronnikov via Tarantool-patches 2023-10-06 10:49 ` Maxim Kokryashkin via Tarantool-patches 2023-10-09 9:27 ` Sergey Kaplun via Tarantool-patches 2023-10-13 10:11 ` Maxim Kokryashkin via Tarantool-patches 2023-10-23 14:59 ` Sergey Kaplun via Tarantool-patches 2023-10-03 16:25 ` Sergey Bronnikov via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=038fe5c1-c421-78a4-02b1-2e0398010ce8@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2] Mark CONV as non-weak, to prevent elimination of its side-effect.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox