From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 2/3] sql: ban sql functions coinciding with builtins
Date: Fri, 17 May 2019 02:12:29 +0300 [thread overview]
Message-ID: <0356C5B8-C1B1-4986-BBC7-5202E877F656@tarantool.org> (raw)
In-Reply-To: <068d058c4b8354f332e67e95761f722ab72cbae0.1557941573.git.kshcherbatov@tarantool.org>
> On 15 May 2019, at 20:34, Kirill Shcherbatov <kshcherbatov@tarantool.org> wrote:
>
> Previously, it was possible to create a function with name
> that is already reserved for some predefined builtin.
> It is a bug. This patch bans sql_create_function for such cases.
>
> Also removed FUNC_PERFECT_MATCH user session flag.
>
> Closes #4219
> Needed for #3691
Could you please split this patch into two: first one would
provide only code style fixes and the second one - functional
changes (i.e. exactly what commit subject says)?
next prev parent reply other threads:[~2019-05-16 23:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 17:34 [tarantool-patches] [PATCH v1 0/3] box: local sql_flags for parser and vdbe Kirill Shcherbatov
2019-05-15 17:34 ` [tarantool-patches] [PATCH v1 1/3] sql: get rid of SQL_NullCallback flag Kirill Shcherbatov
2019-05-16 23:08 ` [tarantool-patches] " n.pettik
2019-05-15 17:34 ` [tarantool-patches] [PATCH v1 2/3] sql: ban sql functions coinciding with builtins Kirill Shcherbatov
2019-05-16 23:12 ` n.pettik [this message]
2019-05-17 8:22 ` [tarantool-patches] " Kirill Shcherbatov
2019-05-17 15:20 ` n.pettik
2019-05-17 8:22 ` Kirill Shcherbatov
2019-05-15 17:34 ` [tarantool-patches] [PATCH v1 3/3] box: local sql_flags for parser and vdbe Kirill Shcherbatov
2019-05-15 18:54 ` [tarantool-patches] " Kirill Shcherbatov
2019-05-16 23:08 ` n.pettik
2019-05-17 8:22 ` Kirill Shcherbatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0356C5B8-C1B1-4986-BBC7-5202E877F656@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 2/3] sql: ban sql functions coinciding with builtins' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox