From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 0/2] sql: Create special region for parser
Date: Thu, 31 May 2018 18:55:40 +0300 [thread overview]
Message-ID: <02431d4f-c7a2-9881-c3fd-7f2d5b041c51@tarantool.org> (raw)
In-Reply-To: <da32aa10-440f-633f-4c88-81644458468f@tarantool.org>
LGTM.
On 31/05/2018 18:50, Kirill Shcherbatov wrote:
> Moved sql_parser_create and sql_parser_destroy to sql.h to
> use them not only in DDL.
> Removed SELECTTRACE_ENABLED macro with conditional fields from
> struct Parse to prevent different object sizes across the project.
> Start use own region for parser to avoid unexpected memory releases.
>
> On 31.05.2018 18:01, Kirill Shcherbatov wrote:
>> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3438-parser-own-region
>> Issue: https://github.com/tarantool/tarantool/issues/3438
>>
>> Kirill Shcherbatov (2):
>> sql: remove parser construct, destruct to sql.h
>> sql: use own region in Parser
>>
>> src/box/sql.h | 17 +++++++++++++++++
>> src/box/sql/build.c | 6 +++---
>> src/box/sql/prepare.c | 11 +++++++++--
>> src/box/sql/select.c | 2 +-
>> src/box/sql/sqliteInt.h | 29 ++---------------------------
>> src/box/sql/tokenize.c | 10 ++++++----
>> 6 files changed, 38 insertions(+), 37 deletions(-)
>>
>
next prev parent reply other threads:[~2018-05-31 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 15:01 [tarantool-patches] " Kirill Shcherbatov
2018-05-31 15:01 ` [tarantool-patches] [PATCH v1 1/2] sql: remove parser construct, destruct to sql.h Kirill Shcherbatov
2018-05-31 15:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-31 15:49 ` Kirill Shcherbatov
2018-05-31 15:01 ` [tarantool-patches] [PATCH v1 2/2] sql: use own region in Parser Kirill Shcherbatov
2018-05-31 15:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-31 15:49 ` Kirill Shcherbatov
2018-05-31 15:41 ` [tarantool-patches] Re: [PATCH v1 0/2] sql: Create special region for parser Vladislav Shpilevoy
2018-05-31 15:50 ` Kirill Shcherbatov
2018-05-31 15:55 ` Vladislav Shpilevoy [this message]
2018-05-31 17:43 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02431d4f-c7a2-9881-c3fd-7f2d5b041c51@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 0/2] sql: Create special region for parser' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox