From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v1 3/3] box: local sql_flags for parser and vdbe Date: Fri, 17 May 2019 11:22:40 +0300 [thread overview] Message-ID: <02355feb-9512-3f22-9d33-633963d14dc0@tarantool.org> (raw) In-Reply-To: <A8FC8EDC-38D2-4966-AA85-AA821BC6114E@tarantool.org> Hi! Thank you for review. box: local sql_flags for parser and vdbe The sql_flags is a parser parameter that describes how to parse the SQL request, determines general behaviour: like whether foreign keys are handled as deferred or not etc. But now this information is taken from the global user session object. When we need to run the parser with some other parameters, it is necessary to change global session object, which may lead to unpredictable consequences in general case. Introduced a new parser and vdbe field sql_flags which is responsible for SQL parsing results. Needed for #3691 > Why not pass only flags from parsing context? Done. > Strictly speaking, they flags are not flags. 'options > The rest is OK.
prev parent reply other threads:[~2019-05-17 8:22 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-15 17:34 [tarantool-patches] [PATCH v1 0/3] " Kirill Shcherbatov 2019-05-15 17:34 ` [tarantool-patches] [PATCH v1 1/3] sql: get rid of SQL_NullCallback flag Kirill Shcherbatov 2019-05-16 23:08 ` [tarantool-patches] " n.pettik 2019-05-15 17:34 ` [tarantool-patches] [PATCH v1 2/3] sql: ban sql functions coinciding with builtins Kirill Shcherbatov 2019-05-16 23:12 ` [tarantool-patches] " n.pettik 2019-05-17 8:22 ` Kirill Shcherbatov 2019-05-17 15:20 ` n.pettik 2019-05-17 8:22 ` Kirill Shcherbatov 2019-05-15 17:34 ` [tarantool-patches] [PATCH v1 3/3] box: local sql_flags for parser and vdbe Kirill Shcherbatov 2019-05-15 18:54 ` [tarantool-patches] " Kirill Shcherbatov 2019-05-16 23:08 ` n.pettik 2019-05-17 8:22 ` Kirill Shcherbatov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=02355feb-9512-3f22-9d33-633963d14dc0@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 3/3] box: local sql_flags for parser and vdbe' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox