Re: [Tarantool-patches] [PATCH v1.1] evio: workaround for wsl1 so_linger assertion

["Timur Safin" <tsafin@tarantool.org>]

: -----Original Message-----
: From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
: Subject: Re: [PATCH v1.1] evio: workaround for wsl1 so_linger assertion
: 
: > Yup, sorry for the omission, I should automate this somehow
: > (because at the moment there are too many manual steps which are
: > easy to forget or to skip. Do you have any advices/scripts here?)
: 
: Yeah, I use this:
: https://gist.github.com/Gerold103/5471a7ddbeec346c0c845930d5bb9df4
: But it is for bash. Don't know whether you use bash on Windows.

That's quite nice. I'll try to automate it even further (i.e. there is no 
much need to provide manual branch information, and the number of patches
to pick - all them could be automatically calculated), but it's very good
start.  

: > :
: > : > +
: > : >  elseif (${CMAKE_SYSTEM_NAME} STREQUAL "kFreeBSD")
: > : >      set(TARGET_OS_FREEBSD 1)
: > : >      set(TARGET_OS_DEBIAN_FREEBSD 1)
: > : > @@ -19,6 +28,7 @@ elseif (${CMAKE_SYSTEM_NAME} STREQUAL "kFreeBSD")
: > : >      add_definitions("-D_FILE_OFFSET_BITS=64")
: > : >      find_package_message(PLATFORM "Building for Debian/kFreeBSD"
: > : >          "${CMAKE_SYSTEM_NAME}")
: > : > +
: > :
: > : Please, omit not necessary diff. This and other new empty lines
: > : below.
: > :
: >
: > Ok, will remove these unnecessary lines added (though they did
: > add some extra readability to the cmake scripts we have here :) )
: 
: Perhaps, but readability is a subjective thing usually. However
: more important is that such unnecessary diff tends to pollute git
: blame, and pad out patch size making it harder to review.

Ok, ok, will get rid of them in next iteration.

Regards,
Timur