From: "Timur Safin" <tsafin@tarantool.org>
To: 'Aleksandr Lyapunov' <alyapunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Simplify alter.cc
Date: Wed, 8 Jul 2020 13:35:12 +0300 [thread overview]
Message-ID: <022401d65513$764e4970$62eadc50$@tarantool.org> (raw)
In-Reply-To: <1594199230-26036-1-git-send-email-alyapunov@tarantool.org>
I'm very much infavor to use less verbose try-function blocks -
they significantly reduce verbosity of a C++ code which should
be in between C++ and C functions. So indeed - that's good idiom.
Although I suspect `noexcept` in C++17 is not that much zero-cost
abstraction (it should be verified with all supported compilers) but looks
like it's not adding any extra overhead which we would not have at the moment.
But I have some (debatable) notes about lambda usage. See in patches...
Timur
: From: Aleksandr Lyapunov
: Subject: [Tarantool-patches] [PATCH 0/2] Simplify alter.cc
:
: Since we use C++ we need to use in a way that benefits its advantages.
: As I see, there are tons of try-catch blocks in alter.cc. We should use
: more modern techniques and approaches.
:
: Aleksandr Lyapunov (2):
: alter: use good c++ style
: alter: use proper way to marry C and C++
:
: src/box/alter.cc | 418 +++++++++++++++++++++++---------------------------
: -----
: 1 file changed, 177 insertions(+), 241 deletions(-)
:
: --
: 2.7.4
next prev parent reply other threads:[~2020-07-08 10:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 9:07 Aleksandr Lyapunov
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 1/2] alter: use good c++ style Aleksandr Lyapunov
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-13 13:36 ` Aleksandr Lyapunov
2020-07-13 18:33 ` Vladislav Shpilevoy
2020-07-13 21:51 ` Timur Safin
2020-07-13 22:17 ` Vladislav Shpilevoy
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 2/2] alter: use proper way to marry C and C++ Aleksandr Lyapunov
2020-07-08 10:41 ` Timur Safin
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-08 9:13 ` [Tarantool-patches] [PATCH 0/2] Simplify alter.cc Aleksandr Lyapunov
2020-07-08 10:35 ` Timur Safin [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-08 8:43 Aleksandr Lyapunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='022401d65513$764e4970$62eadc50$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Simplify alter.cc' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox