From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: disallow to rename space if it is referenced by view
Date: Mon, 10 Dec 2018 14:17:55 +0300 [thread overview]
Message-ID: <01a74281-43c6-d68d-1cd5-daecc62071ad@tarantool.org> (raw)
In-Reply-To: <20181209155735.32694-1-korablev@tarantool.org>
Hi! Thanks for the patch! LGTM.
On 09/12/2018 18:57, Nikita Pettik wrote:
> Before this patch it was allowed to rename space which is referenced by
> a view. In turn, view contains SELECT statement in a raw form (i.e. as a
> string) and it is not modified during renaming routine. Hence, after
> renaming space still has referencing counter > 0, but no usage of view
> is allowed (since execution of SELECT results in "Space does not
> exist"). To avoid such situations, lets ban renaming space if its view
> reference counter > 0.
>
> Note that RENAME is ANSI extension, so different DBs behave in this case
> in different ways - some of them allow to rename tables referenced by a
> view (PostgreSQL), others - don't (Oracle).
>
> Closes #3746
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3746-view-rename
> Issue: https://github.com/tarantool/tarantool/issues/3746
>
next prev parent reply other threads:[~2018-12-10 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 15:57 [tarantool-patches] " Nikita Pettik
2018-12-10 11:17 ` Vladislav Shpilevoy [this message]
2018-12-11 7:02 ` [tarantool-patches] " Konstantin Osipov
2018-12-11 9:57 ` n.pettik
2018-12-25 13:33 ` Kirill Yukhin
2018-12-27 10:14 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a74281-43c6-d68d-1cd5-daecc62071ad@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: disallow to rename space if it is referenced by view' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox