From: Oleg Babin <olegrok@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods
Date: Mon, 8 Jun 2020 18:37:59 +0300 [thread overview]
Message-ID: <0195efc7-f32b-577b-69b7-92bbc5dcde69@tarantool.org> (raw)
In-Reply-To: <20200608153308.GK134822@grain>
On 08/06/2020 18:33, Cyrill Gorcunov wrote:
> On Mon, Jun 08, 2020 at 06:29:25PM +0300, Oleg Babin wrote:
>> Hi! Thanks for your patch. See 1 comment below.
> ...
>>
>> I assume that "box_set_log_level" and "box_set_log_format" should be removed
>> as well.
>
> Nope, they are called when we modify dynamic settings via box.cfg{}.
>
Thanks for explanation. LGTM.
next prev parent reply other threads:[~2020-06-08 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 10:44 [Tarantool-patches] [PATCH 0/3] lua/cfg: drop unused code and extend test Cyrill Gorcunov
2020-06-08 10:44 ` [Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods Cyrill Gorcunov
2020-06-08 15:29 ` Oleg Babin
2020-06-08 15:33 ` Cyrill Gorcunov
2020-06-08 15:37 ` Oleg Babin [this message]
2020-06-08 10:44 ` [Tarantool-patches] [PATCH 2/3] lua/cfg: drop redundant variable Cyrill Gorcunov
2020-06-08 15:31 ` Oleg Babin
2020-06-08 10:44 ` [Tarantool-patches] [PATCH 3/3] test: app-tap/logger -- test symbolic loglevels Cyrill Gorcunov
2020-06-08 15:31 ` Oleg Babin
2020-06-09 8:26 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0195efc7-f32b-577b-69b7-92bbc5dcde69@tarantool.org \
--to=olegrok@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox