[Tarantool-patches] [PATCH] tpch: use normal perf image instead of patched one

[Tarantool-patches] [PATCH] tpch: use normal perf image instead of patched one

[Oleg Koshovetc]

TPCH benchmark used to be launched with numerous patches applied
to tarantool's source code. Not only it does not bench actual
tarantool, it also adds extra complications in benchmarking process.
Recently we got pipeline failed only because of tpch benchmark as it
would fail to launch because it failed to apply all of the needed
patches. Instead of fixing the patches we'd better get rid of that
patching in the first place.
---
  .gitlab-ci.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 208ab24..935a27b 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -328,7 +328,7 @@ perf_tpch:
    <<: *perf_docker_test_definition
    tags:
      - docker_sh2_perf
-  image: ${IMAGE_PERF_BUILT}_tpch
+  image: ${IMAGE_PERF_BUILT}
    variables:
      <<: *perf_vars_definition
      BENCH: 'tpch'
-- 
2.7.4

Re: [Tarantool-patches] [PATCH] tpch: use normal perf image instead of patched one

[Timur Safin]

We need those patches to run whole TPC-H set (specifically Q13, Q17 and Q20, which are biggest outliers and which we have fixed with autoindex patches last quarter). We will return to proper datestamp support in SQL the next quarter Q1'21, unless then we had to live with patches.
 
So, please don't.

Timur
: -----Original Message-----
: From: Oleg Koshovetc <okoshovetc@tarantool.org>
: Sent: Tuesday, December 22, 2020 2:21 AM
: To: Alexander Tikhonov <avtikhon@tarantool.org>; tsafin@tarantool.org
: Cc: tarantool-patches@dev.tarantool.org
: Subject: [PATCH] tpch: use normal perf image instead of patched one
: 
: TPCH benchmark used to be launched with numerous patches applied
: to tarantool's source code. Not only it does not bench actual
: tarantool, it also adds extra complications in benchmarking process.
: Recently we got pipeline failed only because of tpch benchmark as it
: would fail to launch because it failed to apply all of the needed
: patches. Instead of fixing the patches we'd better get rid of that
: patching in the first place.
: ---
:   .gitlab-ci.yml | 2 +-
:   1 file changed, 1 insertion(+), 1 deletion(-)
: 
: diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
: index 208ab24..935a27b 100644
: --- a/.gitlab-ci.yml
: +++ b/.gitlab-ci.yml
: @@ -328,7 +328,7 @@ perf_tpch:
:     <<: *perf_docker_test_definition
:     tags:
:       - docker_sh2_perf
: -  image: ${IMAGE_PERF_BUILT}_tpch
: +  image: ${IMAGE_PERF_BUILT}
:     variables:
:       <<: *perf_vars_definition
:       BENCH: 'tpch'
: --
: 2.7.4
: