From: "Timur Safin" <tsafin@tarantool.org>
To: 'Oleg Koshovetc' <okoshovetc@tarantool.org>,
'Alexander Tikhonov' <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] tpch: use normal perf image instead of patched one
Date: Tue, 22 Dec 2020 12:41:34 +0300 [thread overview]
Message-ID: <013401d6d846$a31040b0$e930c210$@tarantool.org> (raw)
In-Reply-To: <97201353-fc4d-df72-e92c-261cc76107fc@tarantool.org>
We need those patches to run whole TPC-H set (specifically Q13, Q17 and Q20, which are biggest outliers and which we have fixed with autoindex patches last quarter). We will return to proper datestamp support in SQL the next quarter Q1'21, unless then we had to live with patches.
So, please don't.
Timur
: -----Original Message-----
: From: Oleg Koshovetc <okoshovetc@tarantool.org>
: Sent: Tuesday, December 22, 2020 2:21 AM
: To: Alexander Tikhonov <avtikhon@tarantool.org>; tsafin@tarantool.org
: Cc: tarantool-patches@dev.tarantool.org
: Subject: [PATCH] tpch: use normal perf image instead of patched one
:
: TPCH benchmark used to be launched with numerous patches applied
: to tarantool's source code. Not only it does not bench actual
: tarantool, it also adds extra complications in benchmarking process.
: Recently we got pipeline failed only because of tpch benchmark as it
: would fail to launch because it failed to apply all of the needed
: patches. Instead of fixing the patches we'd better get rid of that
: patching in the first place.
: ---
: .gitlab-ci.yml | 2 +-
: 1 file changed, 1 insertion(+), 1 deletion(-)
:
: diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
: index 208ab24..935a27b 100644
: --- a/.gitlab-ci.yml
: +++ b/.gitlab-ci.yml
: @@ -328,7 +328,7 @@ perf_tpch:
: <<: *perf_docker_test_definition
: tags:
: - docker_sh2_perf
: - image: ${IMAGE_PERF_BUILT}_tpch
: + image: ${IMAGE_PERF_BUILT}
: variables:
: <<: *perf_vars_definition
: BENCH: 'tpch'
: --
: 2.7.4
:
prev parent reply other threads:[~2020-12-22 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 23:20 Oleg Koshovetc
2020-12-22 9:41 ` Timur Safin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013401d6d846$a31040b0$e930c210$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=okoshovetc@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] tpch: use normal perf image instead of patched one' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox