From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to write a record with a broken lsn
Date: Fri, 14 Feb 2020 13:46:45 +0300 [thread overview]
Message-ID: <0101E5CD-057D-4AD0-B815-0F09A454075B@tarantool.org> (raw)
In-Reply-To: <20200214072021.GB15237@atlas>
> 14 февр. 2020 г., в 10:20, Konstantin Osipov <kostja.osipov@gmail.com> написал(а):
>
> * sergepetrenko <sergepetrenko@tarantool.org> [20/02/14 09:46]:
>> From: Serge Petrenko <sergepetrenko@tarantool.org>
>>
>> There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't
>> fire in release builds, of course. Let's at least warn the user on an
>> attemt to write a record with a duplicate or otherwise broken lsn.
>
> wart is бородавка.
>
> I think you meant warn :)
>
> otherwise lgtm
>
>
> --
> Konstantin Osipov, Moscow, Russia
> https://scylladb.com
Thanks!
--
Serge Petrenko
sergepetrenko@tarantool.org
next prev parent reply other threads:[~2020-02-14 10:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 21:52 [Tarantool-patches] [PATCH v2 0/4] replication: fix applying of rows originating from local instance sergepetrenko
2020-02-13 21:52 ` [Tarantool-patches] [PATCH v2 1/4] box: expose box_is_orphan method sergepetrenko
2020-02-13 21:52 ` [Tarantool-patches] [PATCH v2 2/4] replication: check for rows to skip in applier correctly sergepetrenko
2020-02-14 7:19 ` Konstantin Osipov
2020-02-14 7:29 ` Konstantin Osipov
2020-02-13 21:52 ` [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to write a record with a broken lsn sergepetrenko
2020-02-14 7:20 ` Konstantin Osipov
2020-02-14 10:46 ` Serge Petrenko [this message]
2020-02-16 16:15 ` Vladislav Shpilevoy
2020-02-18 17:28 ` Serge Petrenko
2020-02-18 21:15 ` Vladislav Shpilevoy
2020-02-19 8:46 ` Serge Petrenko
2020-02-13 21:53 ` [Tarantool-patches] [PATCH v2 4/4] replication: do not promote local_vclock_at_subscribe unnecessarily sergepetrenko
2020-02-14 7:25 ` Konstantin Osipov
2020-02-14 10:46 ` Serge Petrenko
2020-02-14 10:52 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101E5CD-057D-4AD0-B815-0F09A454075B@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to write a record with a broken lsn' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox