From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: fix segfault in pragma table_info
Date: Wed, 5 Feb 2020 23:22:56 +0100 [thread overview]
Message-ID: <00aac4ac-e194-7c45-6cfd-7f288799d262@tarantool.org> (raw)
In-Reply-To: <20200127140420.52553-1-k.sosnin@tarantool.org>
Hi! Thanks for the patch! LGTM.
On 27/01/2020 15:04, Chris Sosnin wrote:
> We should first check that primary key is not NULL.
>
> Closes #4745
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4745-table-info-assertion
> issue: https://github.com/tarantool/tarantool/issues/4745
next prev parent reply other threads:[~2020-02-05 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 14:04 Chris Sosnin
2020-01-28 0:24 ` Vladislav Shpilevoy
2020-01-30 12:04 ` Nikita Pettik
2020-01-30 12:53 ` Chris Sosnin
2020-02-05 22:22 ` Vladislav Shpilevoy [this message]
2020-02-06 17:59 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00aac4ac-e194-7c45-6cfd-7f288799d262@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sql: fix segfault in pragma table_info' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox