Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: kostja@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 0/2] Box.session.sync
Date: Sat, 9 Jun 2018 20:58:28 +0300	[thread overview]
Message-ID: <0084c17c-0529-a7d1-1813-0a066b195711@tarantool.org> (raw)
In-Reply-To: <cover.1528566238.git.v.shpilevoy@tarantool.org>

Sorry. Forgot the description.

The patchset fixes box.session.sync(). Before the patchset
box.session.sync() is session global, and is changed after
a new request arrives. So box.session.sync() can be safely
used only when a connection behind the session is not
multiplexed.

But box.session.push() can be used in a multiplexed
connection and uses box.session.sync() as a default
sync. So it needs box.session.sync() be request local.

On 09/06/2018 20:49, Vladislav Shpilevoy wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3450-session-sync
> Issue: https://github.com/tarantool/tarantool/issues/3450
> 
> Vladislav Shpilevoy (2):
>    fiber: remove fiber local storage
>    session: fix box.session.sync()
> 
>   src/box/iproto.cc             | 11 ++++--
>   src/box/session.cc            |  4 +-
>   src/box/session.h             | 31 ++++++---------
>   src/box/txn.c                 |  2 +-
>   src/box/txn.h                 |  2 +-
>   src/fiber.c                   |  9 +----
>   src/fiber.h                   | 89 ++++++++++++++++++-------------------------
>   src/fiber_channel.c           | 31 +++++----------
>   src/lua/fiber.c               | 19 ++++-----
>   test/box-tap/session.test.lua | 29 +++++++++++++-
>   10 files changed, 106 insertions(+), 121 deletions(-)
> 

      parent reply	other threads:[~2018-06-09 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-09 17:49 [tarantool-patches] " Vladislav Shpilevoy
2018-06-09 17:49 ` [tarantool-patches] [PATCH 1/2] fiber: remove fiber local storage Vladislav Shpilevoy
2018-06-13 21:11   ` [tarantool-patches] " Konstantin Osipov
2018-06-14 17:33     ` Vladislav Shpilevoy
2018-06-09 17:49 ` [tarantool-patches] [PATCH 2/2] session: fix box.session.sync() Vladislav Shpilevoy
2018-06-13 21:13   ` [tarantool-patches] " Konstantin Osipov
2018-06-09 17:58 ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0084c17c-0529-a7d1-1813-0a066b195711@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 0/2] Box.session.sync' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox