[tarantool-patches] Re: [PATCH v9 3/7] sql: remove box.sql.debug()

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch! See 3 comments below.

> commit 1e21fc73be5df524d500723bd3e47066475ee6b9
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Thu Jan 31 14:09:51 2019 +0300
> 
>     sql: remove box.sql.debug()
>     
>     Due to removing of box.sql.execute() it makes sense to remove

1. 'removing' -> 'removal'.

>     box.sql.debug() and move SQL statistics to box.stat.

2. For a foreign reader it is unknown that box.sql.execute() removal
== box.sql removal. Probably, it should be said explicitly, that
we want to remove the whole box.sql.

>     
>     Part or #3505
> 
> diff --git a/test/sql-tap/between.test.lua b/test/sql-tap/between.test.lua
> index d56de4e..1663e39 100755
> --- a/test/sql-tap/between.test.lua
> +++ b/test/sql-tap/between.test.lua
> @@ -51,10 +51,10 @@ test:do_test(
>  -- is done.  Then it appends the names of the table and index used.
>  --
>  local function queryplan(sql)
> -    local sql_sort_count = box.sql.debug().sql_sort_count
> +    local sqlite_sort_count = box.stat.sql().sql_sort_count

3. 'sqlite' -> 'sql'

>      local data = test:execsql(sql)
>      local x = "nosort"
> -    if box.sql.debug().sql_sort_count - sql_sort_count then
> +    if box.stat.sql().sql_sort_count - sqlite_sort_count then
>          x = "sort"
>      end
>      table.insert(data,x)