From: Oleg Babin <olegrok@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>, yaroslav.dynnikov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH v3 2/3] lua/log: allow to use json formatter early
Date: Thu, 2 Jul 2020 13:29:42 +0300 [thread overview]
Message-ID: <0061d10a-2bb5-40c1-d4c3-402296206b3d@tarantool.org> (raw)
In-Reply-To: <20200702101816.GF2256@grain>
Thanks! LGTM.
On 02/07/2020 13:18, Cyrill Gorcunov wrote:
> On Thu, Jul 02, 2020 at 01:05:38PM +0300, Oleg Babin wrote:
>> Hi! Thanks for your patch! LGTM! See one minor nitpick below. I hope you
>> could just force-pushed proposed change.
>>
>> On 02/07/2020 12:50, Cyrill Gorcunov wrote:
>>> -- Set value to log from box.cfg{}.
>>> -local function box_api_cfg_set(key, value)
>>> +local function box_api_cfg_set(cfg, key, value)
>>> local log_key = box2log_keys[key]
>>> + local aux_data
>> Seems this variable is unused and could be dropped.
> Yeah, thanks! Already changed and force pushed.
next prev parent reply other threads:[~2020-07-02 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 9:50 [Tarantool-patches] [PATCH v3 0/3] log: allow json formatter in boottime logger Cyrill Gorcunov
2020-07-02 9:50 ` [Tarantool-patches] [PATCH v3 1/3] core/say: allow to use json in boot logger Cyrill Gorcunov
2020-07-02 9:50 ` [Tarantool-patches] [PATCH v3 2/3] lua/log: allow to use json formatter early Cyrill Gorcunov
2020-07-02 10:05 ` Oleg Babin
2020-07-02 10:18 ` Cyrill Gorcunov
2020-07-02 10:29 ` Oleg Babin [this message]
2020-07-02 9:50 ` [Tarantool-patches] [PATCH v3 3/3] test: app-tap/logger -- test json in boottime logger Cyrill Gorcunov
2020-07-02 10:08 ` [Tarantool-patches] [PATCH v3 0/3] log: allow json formatter " Oleg Babin
2020-07-02 10:46 ` Yaroslav Dynnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0061d10a-2bb5-40c1-d4c3-402296206b3d@tarantool.org \
--to=olegrok@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=yaroslav.dynnikov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH v3 2/3] lua/log: allow to use json formatter early' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox