From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
AKhatskevich <avkhatskevich@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/4] Complete module reload
Date: Mon, 23 Jul 2018 16:31:46 +0300 [thread overview]
Message-ID: <0047207a-712a-1d14-31d3-decf63608719@tarantool.org> (raw)
In-Reply-To: <6ebbf656cf54e40298ffa067551c291beefd1f8c.1532344376.git.avkhatskevich@tarantool.org>
Hi! Thanks for the patch!
> diff --git a/vshard/replicaset.lua b/vshard/replicaset.lua
> index 99f59aa..6c8d477 100644
> --- a/vshard/replicaset.lua
> +++ b/vshard/replicaset.lua
> @@ -21,6 +21,7 @@
> -- requests to the replica>,
> -- net_sequential_fail = <count of sequential failed
> -- requests to the replica>,
> +-- is_outdated = nil/true,
https://github.com/tarantool/vshard/blob/kh/gh-112-reload-mt-2/vshard/replicaset.lua#L24
Looks like the version on the branch actually is outdated
instead of the replica object. Please, push the latest
version.
> -- }
> -- },
> -- master = <master server from the array above>,
> @@ -34,6 +35,7 @@
> -- etalon_bucket_count = <bucket count, that must be stored
> -- on this replicaset to reach the
> -- balance in a cluster>,
> +-- is_outdated = nil/true,
> -- }
> --
> -- replicasets = {
next prev parent reply other threads:[~2018-07-23 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 11:14 [tarantool-patches] [PATCH v2] vshard reload mechanism AKhatskevich
2018-07-23 11:14 ` [tarantool-patches] [PATCH 1/4] Add test on error during reconfigure AKhatskevich
2018-07-23 13:18 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-23 11:14 ` [tarantool-patches] [PATCH 2/4] Complete module reload AKhatskevich
2018-07-23 13:31 ` Vladislav Shpilevoy [this message]
2018-07-23 13:45 ` [tarantool-patches] " Alex Khatskevich
2018-07-23 14:58 ` Vladislav Shpilevoy
2018-07-23 11:14 ` [tarantool-patches] [PATCH 3/4] Tests: separate bootstrap routine to a lua_libs AKhatskevich
2018-07-23 13:36 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-23 17:19 ` Alex Khatskevich
2018-07-23 11:14 ` [tarantool-patches] [PATCH 4/4] Introduce storage reload evolution AKhatskevich
2018-07-23 14:44 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-23 20:10 ` Alex Khatskevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0047207a-712a-1d14-31d3-decf63608719@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=avkhatskevich@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/4] Complete module reload' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox