From: "Timur Safin" <tsafin@tarantool.org>
To: 'Cyrill Gorcunov' <gorcunov@gmail.com>
Cc: 'Cyrill Gorcunov' <gorcunov@tarantool.org>,
'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] evio: workaround for wsl1 so_linger assertion
Date: Mon, 16 Mar 2020 19:04:52 +0300 [thread overview]
Message-ID: <000b01d5fbac$a14afad0$e3e0f070$@tarantool.org> (raw)
In-Reply-To: <20200316153202.GB27301@uranus>
: -----Original Message-----
: From: Cyrill Gorcunov <gorcunov@gmail.com>
: Sent: Monday, March 16, 2020 6:32 PM
: To: Timur Safin <tsafin@tarantool.org>
: Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>; Cyrill Gorcunov
: <gorcunov@tarantool.org>; tarantool-patches@dev.tarantool.org
: Subject: Re: [Tarantool-patches] [PATCH] evio: workaround for wsl1
: so_linger assertion
:
: > +
: > + # There are some subtle differences in Linux kernel calls
: > + # implementation under WSL1 (which should go away with WSL2 kernel)
: > + # so for a moment we introduce a way to distinguish Linux and
: > + # Microsoft/WSL1
: > + if (${CMAKE_SYSTEM} MATCHES "Linux-.*-Microsoft")
: > + add_definitions("-DTARANTOOL_WSL_WORKAROUND_ENABLED=1")
: > + endif()
: > +
:
: Great! Thanks a huge, Timur! Since you mentioned WSL2 maybe we should
: name it -DTARANTOOL_WSL_1 ? I don't insist though.
:
: Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
Agreed, will rename it shortly to *WSL1_WORKAROUND*
Timur
next prev parent reply other threads:[~2020-03-16 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 15:25 Timur Safin
2020-03-16 15:32 ` Cyrill Gorcunov
2020-03-16 16:04 ` Timur Safin [this message]
2020-03-16 16:06 ` Cyrill Gorcunov
2020-03-16 15:31 [Tarantool-patches] Отзыв: " Тимур Сафин
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01d5fbac$a14afad0$e3e0f070$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=gorcunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] evio: workaround for wsl1 so_linger assertion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox