From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] sql: refactor index drop code
Date: Thu, 30 Jan 2020 00:45:03 +0100 [thread overview]
Message-ID: <00024a0d-ff5c-deea-a3d9-89ac46a3903d@tarantool.org> (raw)
In-Reply-To: <20200129223219.GC16149@tarantool.org>
On 29/01/2020 23:32, Nikita Pettik wrote:
> On 29 Jan 22:56, Vladislav Shpilevoy wrote:
>>>> diff --git a/src/box/sql/build.c b/src/box/sql/build.c
>>>> index bc50ecbfa..58a6a8a6b 100644
>>>> --- a/src/box/sql/build.c
>>>> +++ b/src/box/sql/build.c
>>>> @@ -1469,6 +1469,26 @@ vdbe_emit_stat_space_clear(struct Parse *parse, const char *stat_table_name,
>>>> sql_table_delete_from(parse, src_list, where);
>>>> }
>>>>
>>>> +/**
>>>> + * Generate VDBE program to remove entry with @a index_id and @a
>>>> + * space_id from _index space.
>>>
>>> Is @a common shortcat for @param? If so, please share a link to docs,
>>> since I've managed to find only this:
>>> '''
>>> \a <word>
>>> Displays the argument in italics. Use this command to emphasize words.
>>> Use this command to refer to member arguments in the running text.
>>> '''
>>
>> We use @param when describe parameters. In @brief sections we use @a
>> intentionally. Probably because
>>
>> 1) @param is used to attach a description to a paramter, and for
>> nothing else: http://www.doxygen.nl/manual/commands.html#cmdparam
>>
>> 2) @a is just shorter, and we can use parameter name multiple times
>> in @brief, so it is important.
>
> Is this undocumented doxygen feature?:) I failed to find out any description
> of '@a' command except for the one I posted above. Or this is purely Tarantool's
> codestyle convention?
Why undocumented? It is documented, and you've found a correct description.
@a is just an italic font for a next word. It is not for parameter names
only, and is not related to @param. We use it so as parameter names in
function descriptions would be highlighted somehow. Don't know why exactly
@a was chosen instead of, for example, @b (bold) or @c (typewriter font).
next prev parent reply other threads:[~2020-01-29 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 14:21 [Tarantool-patches] [PATCH 0/2] Support <ALTER TABLE DROP CONSTRAINT> Roman Khabibov
2020-01-24 14:21 ` [Tarantool-patches] [PATCH 1/2] sql: refactor index drop code Roman Khabibov
2020-01-28 17:44 ` Nikita Pettik
2020-01-29 21:56 ` Vladislav Shpilevoy
2020-01-29 22:32 ` Nikita Pettik
2020-01-29 23:45 ` Vladislav Shpilevoy [this message]
2020-01-30 11:12 ` Nikita Pettik
2020-01-30 21:05 ` Vladislav Shpilevoy
2020-02-01 17:40 ` Roman Khabibov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00024a0d-ff5c-deea-a3d9-89ac46a3903d@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] sql: refactor index drop code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox