[Tarantool-patches] [PATCH v2 luajit 30/41] perf: adjust scimark-lu in LuaJIT-benches

[Sergey Kaplun]

Hi, Sergey!
Thanks for the review!
Please consider my answer below.

On 02.01.26, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch! LGTM
> 
> Sergey
> 
> On 12/26/25 12:18, Sergey Kaplun wrote:
> > This patch adjusts the aforementioned test to use the benchmark
> > framework introduced before. The default arguments are adjusted
> > according to the <PARAM_x86.txt> file. The arguments to the script still
> > can be provided in the command line run.
> >
> > Checks are omitted since they were not present in the original suite,
> > plus the precise result value depends on the input parameter.
> > ---
> >   perf/LuaJIT-benches/scimark-lu.lua | 20 +++++++++++++++++++-
> >   1 file changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/perf/LuaJIT-benches/scimark-lu.lua b/perf/LuaJIT-benches/scimark-lu.lua
> > index 7636d994..4f521e0b 100644
> > --- a/perf/LuaJIT-benches/scimark-lu.lua
> > +++ b/perf/LuaJIT-benches/scimark-lu.lua
> > @@ -1 +1,19 @@
> > -require("scimark_lib").LU(100)(tonumber(arg and arg[1]) or 5000)
> > +local bench = require("bench").new(arg)
> > +
> > +local cycles = tonumber(arg and arg[1]) or 5000
> Why this option is absent in usage?

I suppose there is no need for it.
This still may be done if you are exploring the benchmark behaviour. But
you will read its sources in this case anyway.

This option is persistent for backward compatibility with the original
version.

> > +
> > +local benchmark
> > +benchmark = {
> > +  name = "scimark_lu",
> > +  -- XXX: The description of tests for the function is too
> > +  -- inconvenient.
> > +  skip_check = true,
> > +  payload = function()
> > +    local flops = require("scimark_lib").LU(100)(cycles)
> > +    benchmark.items = flops
> > +  end,
> > +}
> > +
> > +bench:add(benchmark)
> > +
> > +bench:run_and_report()

-- 
Best regards,
Sergey Kaplun