[Tarantool-patches] [PATCH luajit] test: fix misclib-getmetrics-lapi.test.lua

Sergey Kaplun skaplun at tarantool.org
Tue Oct 15 10:40:06 MSK 2024


Hi, Maxim!
Thanks for the review!
I fixed your comment, rebased branch to the current master, and
force-pushed it.

On 11.10.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a single nit regarding the commit message:
> 
> On Sat, Sep 28, 2024 at 01:33:59PM GMT, Sergey Kaplun wrote:
> > When run under Tarantool, the test may fail if Tarantool already has
> > performed some finalize steps. This patch fixes it by making the test
> > more general.
> > ---
> 
> IMO, it would be more readable to paraphrase like:
> | When executed in Tarantool, the test might fail if Tarantool has
> | already completed certain finalization steps. This patch
> | addresses the issue by making the test more adaptable.
> 
> <snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list