[Tarantool-patches] [PATCH luajit] test: fix misclib-getmetrics-lapi.test.lua

Maxim Kokryashkin m.kokryashkin at tarantool.org
Fri Oct 11 21:51:59 MSK 2024


Hi, Sergey!
Thanks for the patch!
LGTM, except for a single nit regarding the commit message:

On Sat, Sep 28, 2024 at 01:33:59PM GMT, Sergey Kaplun wrote:
> When run under Tarantool, the test may fail if Tarantool already has
> performed some finalize steps. This patch fixes it by making the test
> more general.
> ---

IMO, it would be more readable to paraphrase like:
| When executed in Tarantool, the test might fail if Tarantool has
| already completed certain finalization steps. This patch
| addresses the issue by making the test more adaptable.

<snipped>


More information about the Tarantool-patches mailing list