[Tarantool-patches] [PATCH luajit] Limit CSE for IR_CARG to fix loop optimizations.

Sergey Bronnikov sergeyb at tarantool.org
Fri Oct 11 17:02:05 MSK 2024


Hi, Sergey!

On 08.10.2024 16:25, Sergey Kaplun wrote:

<snipped>

>>> +ffi.cdef[[
>>> +  double sin(double, ...);
>>> +  double cos(double, ...);
>> Why do you use sin/cos with wrong function prototypes if you can take
>>
>> a function with varargs. (printf for example)?
> I suppose this hack is well suited for our testing purposes:
> 1) We don't need to create custom vararg functions and the corresponding
>     C libary.
> 2) Functions usage is obvious. Also, the vararg part will be silently
>     ignored.
>
> Be aware that we need the result of the function's call.
>
Got it. I would add this as a comment. Feel free to ignore.

LGTM
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20241011/0d9e630e/attachment.htm>


More information about the Tarantool-patches mailing list