[Tarantool-patches] [PATCH luajit] Limit CSE for IR_CARG to fix loop optimizations.
Sergey Kaplun
skaplun at tarantool.org
Tue Oct 8 16:25:45 MSK 2024
Hi, Sergey!
Thanks for the review!
Please consider my answer below.
On 08.10.24, Sergey Bronnikov wrote:
> Hi, Sergey!
>
> LGTM with a minor question below.
>
<snipped>
> > +ffi.cdef[[
> > + double sin(double, ...);
> > + double cos(double, ...);
>
> Why do you use sin/cos with wrong function prototypes if you can take
>
> a function with varargs. (printf for example)?
I suppose this hack is well suited for our testing purposes:
1) We don't need to create custom vararg functions and the corresponding
C libary.
2) Functions usage is obvious. Also, the vararg part will be silently
ignored.
Be aware that we need the result of the function's call.
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list