[Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow
Sergey Bronnikov
sergeyb at tarantool.org
Fri Jun 7 13:20:06 MSK 2024
Sergey,
thanks for the patch! See my comments below.
Sergey
On 15.05.2024 15:32, Sergey Kaplun wrote:
> Relates to tarantool/tarantool#8473
> ---
> .github/workflows/sanitizers-testing.yml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
> index 154ebe40..4bf7d023 100644
> --- a/.github/workflows/sanitizers-testing.yml
> +++ b/.github/workflows/sanitizers-testing.yml
> @@ -41,7 +41,7 @@ jobs:
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
> runs-on: [self-hosted, regular, Linux, x86_64]
> name: >
> - LuaJIT with ASan (Linux/x86_64)
> + LuaJIT with ASan and UBSan (Linux/x86_64)
> ${{ matrix.BUILDTYPE }}
> CC:${{ matrix.CC }}
> GC64:ON SYSMALLOC:ON
> @@ -70,9 +70,10 @@ jobs:
> cmake -S . -B ${{ env.BUILDDIR }}
> -G Ninja
> ${{ matrix.CMAKEFLAGS }}
> + -DLUAJIT_ENABLE_GC64=ON
> -DLUAJIT_USE_ASAN=ON
> -DLUAJIT_USE_SYSMALLOC=ON
> - -DLUAJIT_ENABLE_GC64=ON
> + -DLUAJIT_USE_UBSAN=ON
> - name: build
> run: cmake --build . --parallel
> working-directory: ${{ env.BUILDDIR }}
> @@ -91,5 +92,8 @@ jobs:
> symbolize=1: \
> unmap_shadow_on_exit=1: \
> "
> + UBSAN_OPTIONS: "
> + print_stacktrace=1 \
I propose to move these env variables to CMake.
> + "
> run: cmake --build . --parallel --target LuaJIT-test
> working-directory: ${{ env.BUILDDIR }}
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20240607/8a27579e/attachment.htm>
More information about the Tarantool-patches
mailing list