<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Sergey,</p>
<p><br>
</p>
<p>thanks for the patch! See my comments below.<br>
</p>
<p>Sergey<br>
</p>
<div class="moz-cite-prefix">On 15.05.2024 15:32, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org">
<pre class="moz-quote-pre" wrap="">Relates to tarantool/tarantool#8473
---
.github/workflows/sanitizers-testing.yml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
index 154ebe40..4bf7d023 100644
--- a/.github/workflows/sanitizers-testing.yml
+++ b/.github/workflows/sanitizers-testing.yml
@@ -41,7 +41,7 @@ jobs:
CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
runs-on: [self-hosted, regular, Linux, x86_64]
name: >
- LuaJIT with ASan (Linux/x86_64)
+ LuaJIT with ASan and UBSan (Linux/x86_64)
${{ matrix.BUILDTYPE }}
CC:${{ matrix.CC }}
GC64:ON SYSMALLOC:ON
@@ -70,9 +70,10 @@ jobs:
cmake -S . -B ${{ env.BUILDDIR }}
-G Ninja
${{ matrix.CMAKEFLAGS }}
+ -DLUAJIT_ENABLE_GC64=ON
-DLUAJIT_USE_ASAN=ON
-DLUAJIT_USE_SYSMALLOC=ON
- -DLUAJIT_ENABLE_GC64=ON
+ -DLUAJIT_USE_UBSAN=ON
- name: build
run: cmake --build . --parallel
working-directory: ${{ env.BUILDDIR }}
@@ -91,5 +92,8 @@ jobs:
symbolize=1: \
unmap_shadow_on_exit=1: \
"
+ UBSAN_OPTIONS: "
+ print_stacktrace=1 \</pre>
</blockquote>
I propose to move these env variables to CMake.<br>
<blockquote type="cite"
cite="mid:8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org">
<pre class="moz-quote-pre" wrap="">
+ "
run: cmake --build . --parallel --target LuaJIT-test
working-directory: ${{ env.BUILDDIR }}
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>