[Tarantool-patches] [PATCH v2 luajit 24/26] test: enable <api_call.lua> LuaJIT test

Maxim Kokryashkin m.kokryashkin at tarantool.org
Fri Feb 9 19:15:09 MSK 2024


Hi, Sergey!
Thanks for the clarification!
On Tue, Feb 06, 2024 at 05:44:16PM +0300, Sergey Kaplun wrote:
> Hi, Maxim!
> Thanks for the review!
> See my answer below.
>
> On 01.02.24, Maxim Kokryashkin wrote:
> > Hi, Sergey!
> > Thanks for the patch!
> > LGTM, with the same question about moving from <misc> to <lang>.
>
> I suppose that the `misc` name is some stash directory name for orphan
> tests. This directory contains tests related to the JIT engine
> (<jit_flush.lua>, <loop_unroll.lua>).
> But tests like <stackov.lua>, <api_call.lua> or <lightud.lua> are
> related to the language itself, so I suppose it will be better to move
> them there.
>
> > On Mon, Jan 29, 2024 at 01:45:24PM +0300, Sergey Kaplun wrote:
> > > This patch moves the <api_call.lua> test from the <misc> to <lang>
> > > directory, includes it in <index>, and names subtests.
> > >
> > > Part of tarantool/tarantool#9398
> > <snipped>
>
> --
> Best regards,
> Sergey Kaplun


More information about the Tarantool-patches mailing list