[Tarantool-patches] [PATCH v2 luajit 23/26] test: enable <lightud.lua> LuaJIT test

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 17:43:24 MSK 2024


Hi, Maxim!
Thanks for the review!
See my answer below.

On 01.02.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, with a question below.
> On Mon, Jan 29, 2024 at 01:45:23PM +0300, Sergey Kaplun wrote:
> > This patch moves the <lightud.lua> test from the <misc> to <lang>
> What is the rationale for that?

I suppose that the `misc` name is some stash directory name for orphan
tests. This directory contains tests related to the JIT engine
(<jit_flush.lua>, <loop_unroll.lua>).
But tests like <stackov.lua>, <api_call.lua> or <lightud.lua> are
related to the language itself, so I suppose it will be better to move
them there.

> > directory, includes it in <index>, and names subtests. Also, it enables
> > tests for all arches and fixes tests for 47-bit lightuserdata because it
> > is available since the commit
> > 2cacfa8e7ffefb715abf55dc5b0c708c63251868 ("Add support for full-range 64
> > bit lightuserdata.")
> <snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list