[Tarantool-patches] [PATCH v2 luajit 21/26] test: enable <ffi_parse_struct.lua> LuaJIT test

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 17:23:24 MSK 2024


Hi, Maxim!
Thanks for the review!
Fixed your comment below.

On 01.02.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> Please consider my comments below.
> 
> On Mon, Jan 29, 2024 at 01:45:21PM +0300, Sergey Kaplun wrote:

<snipped>

> > +do --- checkfail
> A more elaborate name would be nice.

Fixed.

===================================================================
diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
index cb231c33..60385810 100644
--- a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
+++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
@@ -7,7 +7,7 @@ local fails = require("common.fails")
 local P = ffi.sizeof("void *")
 local A = (ffi.arch == "x86" and not ffi.abi("win")) and 4 or 8
 
-do --- checkfail
+do --- incorrect declarations
   checkfail{
     "struct",
     "struct {",
===================================================================

> > +  checkfail{
> > +    "struct",
> > +    "struct {",
> > +    "struct xx xx {}",
> > +    "struct { int x  }",
> > +    "struct { int x,  }",
> > +    "struct { int x,y  }",
> > +    "struct { void x; }",
> <snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list