[Tarantool-patches] [PATCH v2 luajit 20/26] test: enable <ffi_parse_cdef.lua> in LuaJIT-tests

[Sergey Kaplun]

Hi, Maxim!
Thanks for the review!
Fixed your comment below.

On 01.02.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> Please consider my comments below.
> 
> On Mon, Jan 29, 2024 at 01:45:20PM +0300, Sergey Kaplun wrote:

<snipped>

> > +do --- checkfail
> More elaborate name would be nice.

===================================================================
diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua
index cc123808..c095ff46 100644
--- a/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua
+++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua
@@ -3,7 +3,7 @@ local ffi = require("ffi")
 local checkfail = require("common.ffi.checkfail")
 local checktypes = require("common.ffi.checktypes")
 
-do --- checkfail
+do --- incorrect or unsupported declarations
   checkfail({
     "int",
     "int aa1; int aa2 ",
===================================================================

> > +  checkfail({
> > +    "int",
> > +    "int aa1; int aa2 ",
> > +    "static int x;",
> > +    "static const long long x = 1;", -- NYI
> > +    "static const double x = 1;",	   -- NYI
> > +    "static const bool x = 1;",	   -- NYI (intentional, need true/false)
> > +    "struct { static int x = 1; };",
> > +    ";;static int y"
> > +  }, ffi.cdef)
> > +end
> <snipped>

-- 
Best regards,
Sergey Kaplun