[Tarantool-patches] [PATCH v2 luajit 19/26] test: enable <ffi_parse_basic.lua> in LuaJIT-tests

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 17:15:56 MSK 2024


Hi, Maxim!
Thanks for the review!
Fixed your comment below.

On 01.02.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> Please consider my comments below.
> 
> On Mon, Jan 29, 2024 at 01:45:19PM +0300, Sergey Kaplun wrote:

<snipped>

> > +do --- checkfail
> I would prefer a more elaborate name here.

===================================================================
diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua
index 3b49648c..b072cefb 100644
--- a/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua
+++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua
@@ -3,7 +3,7 @@ local ffi = require("ffi")
 local checkfail = require("common.ffi.checkfail")
 local checktypes = require("common.ffi.checktypes")
 
-do --- checkfail
+do --- incorrect declarations
   checkfail{
     "",
     " ",
===================================================================

> > +  checkfail{

<snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list