[Tarantool-patches] [PATCH v2 luajit 14/26] test: enable <ffi_jit_conv.lua> in LuaJIT-tests

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 16:33:17 MSK 2024


Hi, Sergey!
Thanks for the review!
Fixed your comment below.

On 05.02.24, Sergey Bronnikov wrote:
> Hi, Sergey
> 
> thanks for the patch. LGTM with a minor comment
> 
> On 1/29/24 13:45, Sergey Kaplun wrote:

<snipped>

> > +do --- ligud to pointer
> typo: ligud -> lightud

Fixed as the following (since the test name should be verbose):

===================================================================
diff --git a/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua b/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua
index 0e64fe75..9edf67de 100644
--- a/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua
+++ b/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua
@@ -259,7 +259,7 @@ do --- int16_t array arithmetic
   assert(a[99] == 100)
 end
 
-do --- ligud to pointer
+do --- lightuserdata to pointer
   local ud = ctest.lightud(12345678)
   local s = ffi.new("struct { void *p; }")
   for i=1,100 do
===================================================================

> <snipped>


-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list