[Tarantool-patches] [PATCH v2 luajit 12/26] test: enable <ffi_jit_arith.lua> in LuaJIT-tests

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 16:29:11 MSK 2024


Hi, Maxim!
Thanks for the review!
Fixed your comment below.

On 31.01.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for the single minor comment below.
> On Mon, Jan 29, 2024 at 01:45:12PM +0300, Sergey Kaplun wrote:
> > This patch names all subtests and includes the test in <index>.
> >
> > Part of tarantool/tarantool#9398
> > ---

<snipped>

> >
> > --- ra_destpair
> > -do
> > +
> > +do --- ra_destpair
> Does `ra` means `register allocator`?

Yes, renamed the test case as the following.

===================================================================
diff --git a/test/LuaJIT-tests/lib/ffi/ffi_jit_arith.lua b/test/LuaJIT-tests/lib/ffi/ffi_jit_arith.lua
index efe83cfd..2c866b87 100644
--- a/test/LuaJIT-tests/lib/ffi/ffi_jit_arith.lua
+++ b/test/LuaJIT-tests/lib/ffi/ffi_jit_arith.lua
@@ -143,7 +143,7 @@ do --- char and 0LL base comparisons
 end
 
 
-do --- ra_destpair
+do --- destination register pair (ra_destpair)
   local x, y = 0, 0
   for i=1,100 do
     x = x + i/3LL
===================================================================

> >    local x, y = 0, 0

<snipped>

> >

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list