[Tarantool-patches] [PATCH v2 luajit 11/26] test: enable <ffi_gcstep_recursive.lua>

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 16:23:49 MSK 2024


Hi, Maxim!
Thanks for the revew.
Fixed your comment see the iterative patch below.

On 31.01.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for the single nit below.
> 
> On Mon, Jan 29, 2024 at 01:45:11PM +0300, Sergey Kaplun wrote:
> > This patch declares functions as local to avoid pollution of the global
> > environment. It separates the body of the test in the `do` `while` block
> > and includes the test in <index>.
> >
> > Part of tarantool/tarantool#9398
> > ---
> >  .../lib/ffi/ffi_gcstep_recursive.lua          | 27 ++++++++++---------
> >  test/LuaJIT-tests/lib/ffi/index               |  1 +
> >  2 files changed, 15 insertions(+), 13 deletions(-)
> >
> > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua
> > index cb19df11..f6e0b009 100644
> > --- a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua
> > +++ b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua
> > @@ -1,6 +1,6 @@
> >  -- From Robert G. Jakabosky, 2012-03-20
> >
> > -local N=tonumber(arg[1] or 10000)
> > +local N= 10000
> Something wrong with formatting here.

Fixed.

===================================================================
diff --git a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua
index f6e0b009..3029defd 100644
--- a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua
+++ b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua
@@ -1,6 +1,6 @@
 -- From Robert G. Jakabosky, 2012-03-20
 
-local N= 10000
+local N = 10000
 
 local ffi=require"ffi"

===================================================================

> 
> <snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list