[Tarantool-patches] [PATCH v2 luajit 08/26] test: enable <ffi_const.lua> in LuaJIT-tests

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 15:10:17 MSK 2024


Hi, Sergey!
Thanks for the review!
Fixed your comments and force-pushed the branch.

On 01.02.24, Sergey Bronnikov wrote:
> Hi, Sergey
> 
> thanks for the patch! LGTM with a minor comment below
> 
> On 1/29/24 13:45, Sergey Kaplun wrote:
> > This patch changes the `dofile()` (which uses an unreliable relative
> > file path and mutates `_G` with global functions to be defined) to the
> > corresponding `require()`.  Also, it names the only one test as "misc"
> extra whitespace before "Also"

Fixed, thanks!

> > and includes the test in <index>.
> >
> > Part of tarantool/tarantool#9398
> > ---

The new commit message is the following:

| test: enable <ffi_const.lua> in LuaJIT-tests
|
| This patch changes the `dofile()` (which uses an unreliable relative
| file path and mutates `_G` with global functions to be defined) to the
| corresponding `require()`. Also, it splits the test case into several
| and includes the test in <index>.
|
| Part of tarantool/tarantool#9398

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list