[Tarantool-patches] [PATCH v2 luajit 06/26] test: enable <ffi_call.lua> in LuaJIT-tests

[Sergey Kaplun]

Hi, Sergey!
Thanks for the review!
Fixed your comment.

On 01.02.24, Sergey Bronnikov wrote:
> Hi, Sergey
> 
> thanks for the patch! LGTM with minor comment below
> 
> On 1/29/24 13:45, Sergey Kaplun wrote:
> > This patch removes unused `dofile()`. Also, it uses the basename of the
> > ctest library to be loaded via ffi. It adds groups with names of
> > subtests and enables the test in <index>. Complex type is undefined on
> > Windows, so the correponding tests are not enabled for this platform.
> > Fastcalls are enabled only for the x86 architecture. Stdcalls are
> > enabled only for Windows on x86. Tests with calls with 10 arguments with
> > sizes less than 8 bits are dummy for M1. This suite lacks a mechanism to
> 
> too much "with" for my taste :) feel free to ignore

Replaced the first "with" with:) containing. See the new commit message
below:

| test: enable <ffi_call.lua> in LuaJIT-tests
|
| This patch removes unused `dofile()`. Also, it uses the basename of the
| ctest library to be loaded via ffi. It adds groups with names of
| subtests and enables the test in <index>. Complex type is undefined on
| Windows, so the correponding tests are not enabled for this platform.
| Fastcalls are enabled only for the x86 architecture. Stdcalls are
| enabled only for Windows on x86. Tests containing calls with 10
| arguments with sizes less than 8 bits are dummy for M1. This suite lacks
| a mechanism to skip subtests satisfying complicated conditions, so it is
| done manually by the corresponding `if` check.
|
| Part of tarantool/tarantool#9398

> 
> Thanks for reformatting testcases, much more readable now.

It's a pleasure :).


-- 
Best regards,
Sergey Kaplun