[Tarantool-patches] [PATCH v2 luajit 05/26] test: enable <ffi_bitfield.lua> in LuaJIT-tests

Sergey Bronnikov sergeyb at tarantool.org
Thu Feb 1 18:52:38 MSK 2024


Hi, Sergey

thanks for the patch! LGTM after renaming testcase (I'm agree with Maxim).

BTW don't forget to update commit description after renaming.


On 1/29/24 13:45, Sergey Kaplun wrote:
> This patch removes unused `dofile()`. Also, it names the only one test
> as "misc" and includes the test in <index>.
>
> Part of tarantool/tarantool#9398
> ---
>   test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua | 4 +---
>   test/LuaJIT-tests/lib/ffi/index            | 1 +
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua b/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua
> index cd0b1815..fa74e45d 100644
> --- a/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua
> +++ b/test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua
> @@ -1,8 +1,6 @@
>   local ffi = require("ffi")
>   
> -dofile("../common/ffi_util.inc")
> -
> -do
> +do --- misc
>     local x = ffi.new([[
>       union {
>         uint32_t u;
> diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index
> index 7e046908..8d833107 100644
> --- a/test/LuaJIT-tests/lib/ffi/index
> +++ b/test/LuaJIT-tests/lib/ffi/index
> @@ -3,6 +3,7 @@ cdata_var.lua
>   copy_fill.lua
>   err.lua
>   ffi_arith_ptr.lua
> +ffi_bitfield.lua
>   istype.lua
>   jit_array.lua
>   jit_complex.lua


More information about the Tarantool-patches mailing list