[Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash

Sergey Bronnikov estetus at gmail.com
Fri Dec 6 13:16:38 MSK 2024


Hi, Sergey,

fixes applied and force-pushed.

On 10:55 Fri 06 Dec , Sergey Kaplun wrote:
>Hi, Sergey!
>Thanks for the patch!
>LGTM, with a few nits regarding the commit message.
>
>On 06.12.24, Sergey Bronnikov wrote:
>> From: Sergey Bronnikov <sergeyb at tarantool.org>
>>
>> - fix a typo in a comment
>
>Typo? /fix/Fix/
>Typo? /comment/comment./

Fixed.

>
>> - replace `skip_all()` with `skip()` because it is strange
>
>Typo? /replace/Replace/

Fixed.

>
>>   to skip overall test group inside a testcase.
>
>Typo: s/overall test group/the overall test group/

Fixed.

>
>> ---
>
><snipped>
>
>
>-- 
>Best regards,
>Sergey Kaplun

-- 
sergeyb@


More information about the Tarantool-patches mailing list