[Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash
Sergey Kaplun
skaplun at tarantool.org
Fri Dec 6 10:55:49 MSK 2024
Hi, Sergey!
Thanks for the patch!
LGTM, with a few nits regarding the commit message.
On 06.12.24, Sergey Bronnikov wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
>
> - fix a typo in a comment
Typo? /fix/Fix/
Typo? /comment/comment./
> - replace `skip_all()` with `skip()` because it is strange
Typo? /replace/Replace/
> to skip overall test group inside a testcase.
Typo: s/overall test group/the overall test group/
> ---
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list