[Tarantool-patches] [PATCH luajit] Fix Clang build.

[Maxim Kokryashkin]

Hi, Sergey!
Thanks for you review.
Here is the diff with changes, branch is force-pushed.

===
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index 2c637124..cb4ba57b 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -35,6 +35,7 @@ jobs:
         BUILDTYPE: [Debug, Release]
         GC64: [ON, OFF]
         OS: [Linux, macOS]
+        CC: [gcc, clang]
         include:
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
@@ -45,12 +46,18 @@ jobs:
             GC64: OFF
           - OS: macOS
             GC64: OFF
+          - OS: macOS
+            CC: gcc
+          - ARCH: ARM64
+            OS: Linux
+            CC: clang
     runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
     name: >
       LuaJIT
       (${{ matrix.OS }}/${{ matrix.ARCH }})
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
+      CC:${{ matrix.CC }}
     steps:
       - uses: actions/checkout at v3
         with:
@@ -64,6 +71,7 @@ jobs:
         if: ${{ matrix.OS == 'macOS' }}
       - name: configure
         run: >
+          CC=${{ matrix.CC }}
           cmake -S . -B ${{ env.BUILDDIR }}
           -G Ninja
           ${{ matrix.CMAKEFLAGS }}
===
On Mon, Oct 09, 2023 at 12:13:51PM +0300, Sergey Kaplun wrote:
> Hi, Max!
> Thanks for the patch!
> Please, consider my comment below.
> 
> On 03.10.23, Maksim Kokryashkin wrote:
> > From: Mike Pall <mike>
> > 
> 
> <snipped>
> 
> > 
> > No tests were added since the issue is relevant for a very
> > specific type of very old clang 10.0.0, which is not really
> > relevant for us.
> 
> Indeed, but we should add the testing of clang build to our CI.
> I suppose we may check the following matrix:
> - [GC64, !GC64]
> - [Debug, Release]
> - Linux only
> ARM64 may be omitted for now since it isn't our target platform.
> 
> It should be done aside from ASAN testing just to verify correctness
> under this compiler. Should be easily added to the `test-luajit` matrix
> in the <.github/workflows/testing.yml>:
> 
> > 
> > Maxim Kokryashkin:
> > * added the description for the problem
> > 
> > Part of tarantool/tarantool#9145
> > ---
> > PR: https://github.com/tarantool/tarantool/pull/9215
> > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-595-fix-clang-build
> > Issue: https://github.com/luajit/luajit/issues/595
> 
> <snipped>
> 
> -- 
> Best regards,
> Sergey Kaplun