[Tarantool-patches] [PATCH luajit] Fix Clang build.

Sergey Kaplun skaplun at tarantool.org
Mon Oct 9 12:13:51 MSK 2023


Hi, Max!
Thanks for the patch!
Please, consider my comment below.

On 03.10.23, Maksim Kokryashkin wrote:
> From: Mike Pall <mike>
> 

<snipped>

> 
> No tests were added since the issue is relevant for a very
> specific type of very old clang 10.0.0, which is not really
> relevant for us.

Indeed, but we should add the testing of clang build to our CI.
I suppose we may check the following matrix:
- [GC64, !GC64]
- [Debug, Release]
- Linux only
ARM64 may be omitted for now since it isn't our target platform.

It should be done aside from ASAN testing just to verify correctness
under this compiler. Should be easily added to the `test-luajit` matrix
in the <.github/workflows/testing.yml>:

> 
> Maxim Kokryashkin:
> * added the description for the problem
> 
> Part of tarantool/tarantool#9145
> ---
> PR: https://github.com/tarantool/tarantool/pull/9215
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-595-fix-clang-build
> Issue: https://github.com/luajit/luajit/issues/595

<snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list