[Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers
Sergey Bronnikov
sergeyb at tarantool.org
Wed Oct 4 11:58:30 MSK 2023
On 9/18/23 11:51, Maxim Kokryashkin wrote:
> Hi!
>
> Четверг, 14 сентября 2023, 12:22 +03:00 от Sergey Bronnikov
> <sergeyb at tarantool.org>:
> Hi, Max
>
> Thanks for the fixes!
>
> Two new comments:
>
> $ ./build/src/luajit -ts sysprof.bin
> ./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to
> concatenate
> local 'magic' (a nil value)
>
> Works just fine for me. Make sure you are using the right file.
$ ./build/src/luajit -ts sysprof.bin
$ file sysprof.bin
sysprof.bin: empty
$ ./build/src/luajit -ts sysprof.bin
./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate
local 'magic' (a nil value)
$
>
> Please fix.
>
>
> $ ./build/src/luajit -ts mee
> ./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2
>
>
> Seems the case is not handled in your code, let's fix it.
>
> It is not relevant to flags and should be fixed for both the memprof
> and the sysprof in a separate ticket with refactoring.
I have no objections, what is a number of the ticket?
>
> On 9/12/23 23:03, Maxim Kokryashkin wrote:
> > Hi, Sergey!
> > Thanks for the review!
> > Fixed all of your comments, except for the one about
> > `luacheckrc` and _TARANTOOL. I believe, it should be
> > done in a separate patch.
> >
> <snipped>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20231004/e2384375/attachment.htm>
More information about the Tarantool-patches
mailing list