<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 9/18/23 11:51, Maxim Kokryashkin
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1695027102.987261187@f487.i.mail.ru">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div>Hi!</div>
<div> </div>
<blockquote
style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг,
14 сентября 2023, 12:22 +03:00 от Sergey Bronnikov
<a class="moz-txt-link-rfc2396E" href="mailto:sergeyb@tarantool.org"><sergeyb@tarantool.org></a>:<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<div>
<div id="style_16946833360574353643_BODY">Hi, Max<br>
<br>
Thanks for the fixes!<br>
<br>
Two new comments:<br>
<br>
$ ./build/src/luajit -ts sysprof.bin<br>
./build/src/luajit: ./tools/utils/symtab.lua:107:
attempt to concatenate<br>
local 'magic' (a nil value)</div>
</div>
</div>
</div>
</blockquote>
<div>Works just fine for me. Make sure you are using the right
file.</div>
</blockquote>
<br>
<br>
$ ./build/src/luajit -ts sysprof.bin<br>
$ file sysprof.bin <br>
sysprof.bin: empty<br>
$ ./build/src/luajit -ts sysprof.bin<br>
./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to
concatenate local 'magic' (a nil value)<br>
$ <br>
<br>
<blockquote type="cite"
cite="mid:1695027102.987261187@f487.i.mail.ru">
<blockquote
style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
<div>
<div class="js-helper js-readmsg-msg">
<div>
<div><br>
Please fix.<br>
<br>
<br>
$ ./build/src/luajit -ts mee<br>
./build/src/luajit: ./tools/utils/bufread.lua:122:
fopen, errno: 2<br>
<br>
<br>
Seems the case is not handled in your code, let's fix
it.</div>
</div>
</div>
</div>
</blockquote>
<div>It is not relevant to flags and should be fixed for both the
memprof</div>
<div>and the sysprof in a separate ticket with refactoring.</div>
</blockquote>
<p>I have no objections, what is a number of the ticket?</p>
<p><br>
</p>
<br>
<blockquote type="cite"
cite="mid:1695027102.987261187@f487.i.mail.ru">
<div> </div>
<blockquote
style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
<div>
<div class="js-helper js-readmsg-msg">
<div>
<div><br>
On 9/12/23 23:03, Maxim Kokryashkin wrote:
<div class="mail-quote-collapse">> Hi, Sergey!<br>
> Thanks for the review!<br>
> Fixed all of your comments, except for the one
about<br>
> `luacheckrc` and _TARANTOOL. I believe, it should
be<br>
> done in a separate patch.<br>
></div>
<snipped></div>
</div>
</div>
</div>
</blockquote>
<div> </div>
</blockquote>
</body>
</html>