[Tarantool-patches] [PATCH luajit v2 1/5] test: disable `lj-603-snap-restore` test

[Maxim Kokryashkin]

Hi!
>
>On 14.03.23, Maxim Kokryashkin wrote:
>> The test is extremely fragile and it is burdening
>> to fix it in scope of every major change.
>> ---
>> test/tarantool-tests/lj-603-err-snap-restore.test.lua | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/test/tarantool-tests/lj-603-err-snap-restore.test.lua b/test/tarantool-tests/lj-603-err-snap-restore.test.lua
>> index 6eb53dfd..2f2eec7d 100644
>> --- a/test/tarantool-tests/lj-603-err-snap-restore.test.lua
>> +++ b/test/tarantool-tests/lj-603-err-snap-restore.test.lua
>> @@ -2,7 +2,9 @@ local tap = require('tap')
>> -- Test to demonstrate the incorrect JIT behaviour when an error
>> -- is raised on restoration from the snapshot.
>> -- See also  https://github.com/LuaJIT/LuaJIT/issues/603 .
>> -local test = tap.test('lj-603-err-snap-restore')
>> +local test = tap.test('lj-603-err-snap-restore'):skipcond({
>> + ['Too fragile, temporarily disabled.'] = true
>> +})
>
>I've reverted your patch at the last commit (4d5e9afe) and everything
>working just fine. I suggest to drop these changes.
No, it does not work. Here is the branch[1] with that commit dropped,
and CI fails exactly because of that test. Moreover, I’ve tried to fix
that by declaring different amounts of local variables in the test
and it seems like it is necessary to declare different amounts for
GC64 and non-GC64 modes. 
 
[1]:  https://github.com/tarantool/luajit/tree/fckxorg/gh-7745-exp-excep
--
Best regards,
Maxim Kokryashkin
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20230320/f5b90175/attachment.htm>