[Tarantool-patches] [PATCH luajit 1/2] Fix use-def analysis for BC_VARG.

[Maxim Kokryashkin]

Hi!
Thanks for the fix!
LGTM
> 
>>Hi, Maxim!
>>Thanks for the review!
>>Fixed your comment and force-pushed the branch.
>>
>>On 22.06.23, Maxim Kokryashkin wrote:
>>>
>>> Hi!
>>> Thanks for the fixes!
>>> LGTM, except for a single nit below.
>>>  
>>> > 
>>
>><snipped>
>>
>>> >>> > >>+-- Test file to demonstrate LuaJIT misbehaviour in use-def
>>> >>> > >>+-- snapshot analysis for BC_VARG.
>>> >>> > >>+-- See also  https://github.com/LuaJIT/LuaJIT/issues/704 .
>>> >>> > >>+local test = tap.test('lj-704-bc-varg-use-def'):skipcond({
>>> >>> > >>+ ['Test requires JIT enabled'] = not jit.status(),
>>> >>> > >>+})
>>> >>> > >>+
>>> >>> > >>+test:plan(1)
>>> >>> > >>+
>>> >>> > >>+-- XXX: we don't really need to store this builtins, but this is
>>> >>> > >Typo: s/this/these/
>>> >>>
>>> >>> Fixed, thanks!
>>> >Typo: s/this is/this/
>>
>>Fixed, thanks!
>>
>>> >>>
>>
>><snipped>
>>
>>> >--
>>> >Best regards,
>>> >Maxim Kokryashkin
>>> > 
>>
>>--
>>Best regards,
>>Sergey Kaplun
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20230628/d7efd353/attachment.htm>