<HTML><BODY><div>Hi!</div><div>Thanks for the fix!</div><div>LGTM</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16879478200302571654_BODY">Hi, Maxim!<br>Thanks for the review!<br>Fixed your comment and force-pushed the branch.<br><br>On 22.06.23, Maxim Kokryashkin wrote:<br>><br>> Hi!<br>> Thanks for the fixes!<br>> LGTM, except for a single nit below.<br>> <br>> > <br><br><snipped><br><br>> >>> > >>+-- Test file to demonstrate LuaJIT misbehaviour in use-def<br>> >>> > >>+-- snapshot analysis for BC_VARG.<br>> >>> > >>+-- See also <a href="https://github.com/LuaJIT/LuaJIT/issues/704" target="_blank">https://github.com/LuaJIT/LuaJIT/issues/704</a> .<br>> >>> > >>+local test = tap.test('lj-704-bc-varg-use-def'):skipcond({<br>> >>> > >>+ ['Test requires JIT enabled'] = not jit.status(),<br>> >>> > >>+})<br>> >>> > >>+<br>> >>> > >>+test:plan(1)<br>> >>> > >>+<br>> >>> > >>+-- XXX: we don't really need to store this builtins, but this is<br>> >>> > >Typo: s/this/these/<br>> >>><br>> >>> Fixed, thanks!<br>> >Typo: s/this is/this/<br><br>Fixed, thanks!<br><br>> >>><br><br><snipped><br><br>> >--<br>> >Best regards,<br>> >Maxim Kokryashkin<br>> > <br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>