[Tarantool-patches] [PATCH luajit 12/19] DynASM: Fix warning.

Sergey Bronnikov sergeyb at tarantool.org
Thu Aug 17 10:39:27 MSK 2023


Hi, Sergey!


Thanks for the patch! LGTM


On 8/9/23 18:36, Sergey Kaplun wrote:
> From: Mike Pall <mike>
>
> (cherry-picked from commit 9b41062156779160b88fe5e1eb1ece1ee1fe6a74)
>
> This patch adds the `/* fallthrough */` comments elsewhere, where it was
> missing for the ARM64 build, so the `-Wimplicit-fallthrough` [1] warning
> is trigerred.
>
> [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough
>
> Sergey Kaplun:
> * added the description for the commit
>
> Part of tarantool/tarantool#8825
> ---
>   dynasm/dasm_arm64.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/dynasm/dasm_arm64.h b/dynasm/dasm_arm64.h
> index 47e1e074..ff21236d 100644
> --- a/dynasm/dasm_arm64.h
> +++ b/dynasm/dasm_arm64.h
> @@ -427,6 +427,7 @@ int dasm_encode(Dst_DECL, void *buffer)
>   	  break;
>   	case DASM_REL_LG:
>   	  CK(n >= 0, UNDEF_LG);
> +	  /* fallthrough */
>   	case DASM_REL_PC:
>   	  CK(n >= 0, UNDEF_PC);
>   	  n = *DASM_POS2PTR(D, n) - (int)((char *)cp - base) + 4;


More information about the Tarantool-patches mailing list