[Tarantool-patches] [PATCH luajit 12/19] DynASM: Fix warning.

Sergey Kaplun skaplun at tarantool.org
Wed Aug 16 17:01:56 MSK 2023


Hi, Maxim!
Thanks for the review!
Rephrased the commit message, as you've suggested.

On 15.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM as trivial, except for the single comment regarding the commit message below.
> On Wed, Aug 09, 2023 at 06:36:01PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> > From: Mike Pall <mike>
> > 
> > (cherry-picked from commit 9b41062156779160b88fe5e1eb1ece1ee1fe6a74)
> > 
> > This patch adds the `/* fallthrough */` comments elsewhere, where it was
> > missing for the ARM64 build, so the `-Wimplicit-fallthrough` [1] warning
> > is trigerred.
> Since there are no 'comments', but the single 'comment', I believe a better phrasing
> would be:
> | This patch adds the `/* fallthrough */` comment to dynasm/dasm_arm64.h, so the
> | `-Wimplicit-fallthrough` [1] warning is not trigerred anymore for the ARM64 build.

Fixed, thanks!

> > 
> > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough
> > 
> > Sergey Kaplun:
> > * added the description for the commit
> > 
> > Part of tarantool/tarantool#8825
> > ---

<snipped>

> > 2.41.0
> > 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list