[Tarantool-patches] [PATCH luajit] ci: make GitHub workflows more CMake-ish
Igor Munkin
imun at tarantool.org
Mon Jun 6 13:18:48 MSK 2022
Sergey,
Thanks for your review!
On 03.06.22, Sergey Bronnikov wrote:
> Thanks for changes!
>
> LGTM now with one note - seems passing "--parallel" for target
Added your tag:
| Reviewed-by: Sergey Bronnikov <sergeyb at tarantool.org>
> "LuaJIT-luacheck" is useless because:
>
> 1. luacheck requires LuaLanes for enabling multithreading and it is not
> installed in LuaJIT CI
>
> 2. option "--jobs" is not passed for luacheck in test/CMakeLists.txt
>
> Feel free to keep patch as is, we can enable option "--jobs" and install
> required LuaLanes module later
>
> in a separate patch.
I've removed "-j" for LuaJIT-luacheck. Diff is below:
================================================================================
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 3091c10b..e2d353e9 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -45,4 +45,4 @@ jobs:
- name: configure
run: cmake .
- name: test
- run: cmake --build . --parallel $(($(nproc) + 1) --target LuaJIT-luacheck
+ run: cmake --build . --target LuaJIT-luacheck
================================================================================
>
> Sergey
>
<snipped>
--
Best regards,
IM
More information about the Tarantool-patches
mailing list