[Tarantool-patches] [PATCH luajit] ci: make GitHub workflows more CMake-ish
Sergey Bronnikov
sergeyb at tarantool.org
Fri Jun 3 13:15:17 MSK 2022
Thanks for changes!
LGTM now with one note - seems passing "--parallel" for target
"LuaJIT-luacheck" is useless because:
1. luacheck requires LuaLanes for enabling multithreading and it is not
installed in LuaJIT CI
2. option "--jobs" is not passed for luacheck in test/CMakeLists.txt
Feel free to keep patch as is, we can enable option "--jobs" and install
required LuaLanes module later
in a separate patch.
Sergey
On 02.06.2022 19:00, Igor Munkin wrote:
> <snipped>
> ================================================================================
>
> diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> index c629e5f4..3091c10b 100644
> --- a/.github/workflows/lint.yml
> +++ b/.github/workflows/lint.yml
> @@ -45,4 +45,4 @@ jobs:
> - name: configure
> run: cmake .
> - name: test
> - run: cmake --build . --parallel --target LuaJIT-luacheck
> + run: cmake --build . --parallel $(($(nproc) + 1) --target LuaJIT-luacheck
>
<snipped>
More information about the Tarantool-patches
mailing list