[Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments.
Sergey Kaplun
skaplun at tarantool.org
Fri Jan 28 18:12:21 MSK 2022
Igor,
On 28.01.22, Igor Munkin wrote:
> Sergey,
>
> On 28.01.22, Sergey Kaplun wrote:
> > Igor,
> > Thanks for the review!
> >
>
> <snipped>
>
> > >
> > > I see no assertion running the test in Debug, unfortunately. Could you
> > > please provide the way to hit it?
> >
> > I build as usual:
> > | $ cmake . -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON && make -j
>
> PEBKAC, I totally forgot to enable LUA_USE_APICHECK and LUA_USE_ASSERT.
> I guess it's time to enable both by default for Debug. Thoughts?
I'm OK with it. Not against at least. :)
>
> <snipped>
>
> >
> > --
> > Best regards,
> > Sergey Kaplun
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list